Generate lockfile for using twine #5841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
requested review from
a team,
amanda11,
arm4b,
nzlosh,
rush-skills and
winem
pull-request-size
bot
added
the
size/XXL
Eric-Arellano
approved these changes
Dec 7, 2022
nzlosh
approved these changes
Dec 8, 2022
pants uses twine when publishing wheels
cognifloyd
force-pushed
the
pants-twine
branch
from
2eb18db to
b5a670f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:
Overview of this PR
This configures pants and generates a lockfile so it can use
twinewhen running thepublishgoal to publish wheels to pypi.We will still need more config before we can use pants to just build wheels, let alone publish them. But, this is the last lockfile I know of that we need. Getting this in now reduces the diff with my PoC branch so it is easier to plan the next PRs.
Here is the
pants.tomlconfig this PR adds:st2/pants.toml
Lines 150 to 152 in 2eb18db
twine version
I copied the pants' default version for twine: https://www.pantsbuild.org/v2.14/docs/reference-twine#version
lockfiles/twine.lock
This lockfile differs from the one that comes with pants because we have different python interpreter constraints.