Skip to content

Conversation

@amanda11
Copy link
Contributor

Update housekeeping so that it can delete tokens that have expired.

@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Jul 19, 2022
@amanda11 amanda11 added this to the 3.8.0 milestone Jul 19, 2022
Copy link
Member

@rush-skills rush-skills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Contributed by @cognifloyd

* Added purging of old tokens. #56791
Contributed by Amanda McGuinness (@amanda11 intive)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using the (@username <orgname>) anywhere else in the changelogs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a few examples. It's really up to the person who wrote the PR. Some people opt not to include a "Contributed by" bit in the changelog. Others need to credit their employer (intive in the case of Amanda).

@cognifloyd cognifloyd enabled auto-merge July 20, 2022 01:16
@cognifloyd cognifloyd merged commit 8726092 into master Jul 21, 2022
@cognifloyd cognifloyd deleted the token_ttl branch July 21, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement size/L PR that changes 100-499 lines. Requires some effort to review.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants