Skip to content

Conversation

@khushboobhatia01
Copy link
Contributor

@khushboobhatia01 khushboobhatia01 commented Nov 8, 2021

This PR adds a wait on runner shutdown for all the ongoing executions to complete.

PR has dependency - #5396

(Ref #5373)

@pull-request-size pull-request-size bot added the size/L PR that changes 100-499 lines. Requires some effort to review. label Nov 8, 2021
@khushboobhatia01 khushboobhatia01 changed the title Implement graceful shutdown of action runner. WIP: Implement graceful shutdown of action runner. Nov 8, 2021
@arm4b arm4b requested review from Kami and m4dcoder November 10, 2021 13:28
Kami
Kami previously requested changes Nov 11, 2021
@khushboobhatia01
Copy link
Contributor Author

@Kami Please review the updated changes.

@arm4b arm4b requested a review from Kami November 15, 2021 20:27
@arm4b arm4b added this to the 3.7.0 milestone Nov 15, 2021
@khushboobhatia01 khushboobhatia01 changed the title WIP: Implement graceful shutdown of action runner. Graceful shutdown of action runner. Dec 3, 2021
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm really looking forward to using this change in prod.

@cognifloyd cognifloyd dismissed Kami’s stale review January 13, 2022 17:23

Review comments addressed

@khushboobhatia01 khushboobhatia01 force-pushed the runner_graceful_shutdown branch from f11c02c to e3da36b Compare January 18, 2022 04:29
@cognifloyd cognifloyd merged commit 0a70387 into StackStorm:master Jan 18, 2022
amanda11 pushed a commit that referenced this pull request Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature service: action runner size/L PR that changes 100-499 lines. Requires some effort to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants