Skip to content

Bug fix in modified action delete API #5351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Bug fix in modified action delete API #5351

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5194f38
Bug fix in modified action delete API
ashwini-orchestral Sep 2, 2021
3900f03
Adding unit tests
ashwini-orchestral Sep 3, 2021
65b4827
Updating unit tests and fixing error code incase of permission error …
ashwini-orchestral Sep 6, 2021
11920b1
Merge branch 'master' into delete_api
ashwini-orchestral Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions st2api/st2api/controllers/v1/actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,9 @@ def delete(self, ref_or_id, requester_user):
"Exception was %s",
e,
)
action = ActionAPI.from_model(action_db)
action_db = ActionAPI.to_model(action)
Copy link
Contributor

@m4dcoder m4dcoder Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to covert the models to ActionAPI and back to ActionDB here?

Action.add_or_update(action_db)
Copy link
Contributor

@m4dcoder m4dcoder Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you modify the unit tests to cover this change?

abort(http_client.INTERNAL_SERVER_ERROR, six.text_type(e))
Copy link
Contributor

@m4dcoder m4dcoder Sep 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if the deletion is related to permission error, can you change the error code to 403 Forbidden here? Otherwise for any other error, return 500 is fine.

return

Expand Down