Skip to content

Conversation

@m4dcoder
Copy link
Contributor

The get uid method for the concurrency policies is not used. Remove related methods to avoid confusion.

The get uid method for the concurrency policies is not used. Remove
related methods to avoid confusion.
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label May 20, 2021
@m4dcoder m4dcoder requested a review from amanda11 May 20, 2021 04:53
@m4dcoder m4dcoder added this to the 3.5.0 milestone May 20, 2021
Copy link
Contributor

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry but otherwise looks good.

Copy link
Contributor

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armab will be happy if you add the PR number to the changelog entry. 😉

CHANGELOG.rst Outdated

Contributed by @khushboobhatia01.

* Clean up to remove unused methods in the action execution concurrency policies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Clean up to remove unused methods in the action execution concurrency policies.
* Clean up to remove unused methods in the action execution concurrency policies. #5268

@m4dcoder m4dcoder merged commit 79fe7d8 into master May 20, 2021
@m4dcoder m4dcoder deleted the cleanup-policies branch May 20, 2021 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M PR that changes 30-99 lines. Good size to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants