Warn on service startup if a non utf-8 encoding is used #5182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to troubleshoot locale / encoding related issue. Also make sure we print those version related messages under INFO log level instead of DEBUG since they may be material when troubleshooting various issues so we should use INFO.
pull-request-size
bot
added
the
size/L
infinite loop when trying to format the message field when StackStorm process was not using utf-8 encoding and when unicode sequence was logged.
pull-request-size
bot
added
size/XL
Co-authored-by: Jacob Floyd <[email protected]>
|
Kick the travis CI job. There's a race condition in some of the orquesta tests. It's looking for status "canceling" but it is already "canceled" at that point. Re-run and it'll probably pass. |
Merged
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates service start up code to log a warning if non utf-8 locale / encoding is used for StackStorm service process.
Background, Context
As encountered recently (and bubbled up by the Xenial end to end tests), using a non utf-8 locale when running StackStorm under Python 3 and working with unicode data can cause all kinds of issues.
There isn't tons we can do to work around those issues in code, but at the very least, we should emit a warning if such scenario is detected and warn the users.