Skip to content

Conversation

@nmaludy
Copy link
Member

@nmaludy nmaludy commented Jul 21, 2020

We've been seeing repeated build failures for codecov issues: https://travis-ci.org/github/StackStorm/st2/jobs/710376520#L27406

The fix is to upgrade to codecov-python >= 2.1 per https://community.codecov.io/t/http-400-while-uploading-to-s3-with-python-codecov-from-travis/1428/6

However, we are maintaining our own fork of codecov-python and those changes haven't been merged into our fork.

Couple things here:

Until we get the changes merged upstream, i've also submitted a PR against our own codecov-python fork to pull in the upstream changes so our tests can pass again without these errors: StackStorm/codecov-python#2

DECISION POINTS / OPTIONS

  1. If we don't mind having the "better error messages" shown in case of codecov failure, we can merge this PR and just use upstream
  • At some point in the future our "better error messages" PR will be merged and we'll take advantage of that automatically
  1. We can let this PR sit until the upstream changes are merged and instead merge PR Sync with upstream master into our special branch codecov-python#2 so we can stop getting errors in our builds.

@nmaludy nmaludy added the bug label Jul 21, 2020
@nmaludy nmaludy requested review from Kami, arm4b, blag and punkrokk July 21, 2020 15:22
@nmaludy nmaludy self-assigned this Jul 21, 2020
@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Jul 21, 2020
@nmaludy nmaludy changed the title [BLOCKED] Use upstream codecov instead of our own fork Use upstream codecov instead of our own fork Jul 21, 2020
@punkrokk
Copy link
Member

Just restarted the failed job

@nmaludy nmaludy added this to the 3.3.0 milestone Jul 23, 2020
Co-authored-by: Eugen C. <[email protected]>
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging in deeper trying to fix the Codecov issues in st2 CI 👍

@nmaludy nmaludy merged commit 2fa206b into master Jul 23, 2020
@nmaludy nmaludy deleted the feature/use-upstream-codecov branch July 23, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug size/XS PR that changes 0-9 lines. Quick fix/merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants