remove deprecated ssl and duplicate proxy host header #4966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
arm4b
reviewed
Jun 12, 2020
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
The code looks good.
You might need to mention this bugfix in the Changelog.
nmaludy
approved these changes
Jun 12, 2020
Member
nmaludy
left a comment
nmaludy
left a comment
There was a problem hiding this comment.
Good catch on the duplicate Host entries 👍
Member
Author
|
@armab I added this to changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes:
ssl ondirective with is deprecated and redundant withlisten *:443 ssl;directiveTested