Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Dec 16, 2019

This pull request updates pymongo to the latest version.

Issue which has prevent us from upgrading in the past (https://jira.mongodb.org/browse/PYTHON-1966) has been resolved in the latest release.

NOTE: Some of the SSL / TLS related constructor arguments have been renamed, but the old names still work so I skipped renaming those arguments for now - https://api.mongodb.com/python/current/changelog.html#changes-in-version-3-9-0.

Issue which has prevented us from upgrading in the past
(https://jira.mongodb.org/browse/PYTHON-1966) has been resolved.
@Kami Kami added this to the 3.2.0 milestone Dec 16, 2019
@pull-request-size pull-request-size bot added the size/XS PR that changes 0-9 lines. Quick fix/merge. label Dec 16, 2019
gitpython==2.1.11
jsonschema==2.6.0
pymongo==3.7.2
pymongo==3.10.0
Copy link
Member

@arm4b arm4b Dec 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I remember requirements.txt needs to be re-generated too based on this file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, need to add generated files, was waiting on tests to pass first :)

Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞 Hopefully no regressions with another pymongo upgrade.

@Kami Kami merged commit 9fd42c2 into master Dec 16, 2019
@Kami Kami deleted the update_pymongo branch December 17, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external dependency mongodb size/XS PR that changes 0-9 lines. Quick fix/merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants