fixing enterprise ldap issue with execution view

[jdmeyer3]

Closes #4758

The error caused in #4758 is because the ldap rbac is expecting the document returned from the ActionExecutionDB to contain action.pack and action.uid, but they are currently not being returned.

Here is the traceback I got from the rbac

Traceback (most recent call last):
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2rbac_enterprise_backend/utils.py", line 120, in assert_user_has_resource_db_permission
    permission_type=permission_type)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2rbac_enterprise_backend/utils.py", line 287, in user_has_resource_db_permission
    permission_type=permission_type)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2rbac_enterprise_backend/resolvers.py", line 673, in user_has_resource_db_permission
    pack_db = PackDB(ref=action['pack'])
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/mongoengine/base/datastructures.py", line 54, in __getitem__
    value = super(BaseDict, self).__getitem__(key)
KeyError: 'pack'

and here is the action object that is returned when it gets the key error

<ActionExecutionDB: ActionExecutionDB(action={u'parameters': {u'pack': {u'required': True, u'type': u'string', u'description': u'Name of pack to lookup'}}}, children=[], context={}, delay=None, end_timestamp=None, id=5d49d6ddf55f7d00f89a00e7, liveaction={}, log=[], parameters={u'log_level': u'DEBUG', u'pack': u'packs'}, parent=None, result={u'result': {u'git_status': None, u'pack': {u'description': u'Pack management functionality.', u'author': u'StackStorm, Inc.', u'python_versions': [u'2', u'3'], u'version': u'3.1.0', u'email': u'[email protected]', u'name': u'packs'}}, u'exit_code': 0, u'stderr': u'', u'stdout': u''}, rule={}, runner={u'runner_parameters': {u'debug': {u'default': False, u'required': False, u'type': u'boolean', u'description': u'Enable runner debug mode.'}, u'content_version': {u'required': False, u'type': u'string', u'description': u'Git revision of the pack content to use for this action execution (git commit sha / tag / branch). Only applies to packs which are git repositories.'}, u'log_level': {u'default': u'DEBUG', u'enum': [u'AUDIT', u'CRITICAL', u'ERROR', u'WARNING', u'INFO', u'DEBUG'], u'type': u'string', u'description': u'Default log level for Python runner actions.'}, u'env': {u'type': u'object', u'description': u'Environment variables which will be available to the script.'}, u'timeout': {u'default': 600, u'type': u'integer', u'description': u"Action timeout in seconds. Action will get killed if it doesn't finish in timeout seconds."}}}, start_timestamp="2019-08-06 19:58:10.371616+00:00", status=None, task_execution=None, trigger={}, trigger_instance={}, trigger_type={}, web_url=None, workflow_execution=None)>

By having mongo return the action.pack, and the action.uid, it should satisfy the st2rbac requirements

[CLAassistant]

All committers have signed the CLA.

[VineeshJain]

Thanks for your contribution @jdmeyer3 , we will review it and merge.

[Kami]

In theory, we could only include that if rbac is enabled, but since those attributes are quite small, it doesn't hurt to include them in all the responses...

[Kami]

Thanks for contributing this bug fix.

I will go ahead and add a corresponding test case to our proprietary RBAC code base.

[Kami]

While working on the tests, I noticed there is another bug hiding in there.

When, rbac.permission_isolation config option is enabled, context attribute is mandatory as well - 9a712d9.

[Kami]

And to clarify / add some context - I believe this issue would only affect WebUI by default, but not CLI, since WebUI tries to retrieve less fields (only the ones it needs) to speed things up.

[m4dcoder]

Where is this value set to True for the tests below?

[m4dcoder]

Can you explain where self.rbac_enabled is set to True and also how is adding the user here test the changes?