Install pack with the latest tag #4743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Have you actually test this change on a pack at GitHub with a tag? If so, can you post the output here? Thanks. |
arm4b
reviewed
Jul 16, 2019
Member
|
Also closes #4384 (#4384 (comment)) |
Contributor
Author
Yes. |
Contributor
|
@jinpingh Can you post the output here for test against a real pack? Thanks. |
arm4b
reviewed
Jul 16, 2019
arm4b
reviewed
Jul 16, 2019
Contributor
Author
|
arm4b
suggested changes
Jul 16, 2019
arm4b
reviewed
Jul 17, 2019
arm4b
reviewed
Jul 17, 2019
jinpingh
force-pushed
the
issue-354/install-pack-latest-tag
branch
from
a363763 to
c50c8c6
Compare
First part of Fixes StackStorm/discussions#354. If pack version is not specified, install the latest version from pack index.json (https://index.stackstorm.org/v1/index.json), otherwise install from master branch as today. Note: Direct github/repo install is not considered an Exchange index hit, therefore it is not covert by this fix.
jinpingh
force-pushed
the
issue-354/install-pack-latest-tag
branch
from
c50c8c6 to
429e986
Compare
arm4b
reviewed
Jul 18, 2019
Root cause: Value passed to arg_ref for `fake_commit` is `v0.4.0` after new code changes, but local `ref` is None. So it failed comparison at line https://github.com/StackStorm/st2/blob/c0458f1a06c2a81cac81697817c422ffb7631047/contrib/packs/tests/test_action_download.py#L523 and mocked `gitref` value is not returned.
arm4b
suggested changes
Jul 22, 2019
Member
There was a problem hiding this comment.
Good work on finding the exact place for this change and fixing the old tests 👍
Please include a new dedicated test case that would cover and verify new behavior exclusively: st2 pack install will install latest stable release version/tag, taken from exchange index.
jinpingh
force-pushed
the
issue-354/install-pack-latest-tag
branch
from
26ab318 to
219c9a2
Compare
arm4b
reviewed
Jul 23, 2019
arm4b
approved these changes
Jul 23, 2019
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Looks good 👍
Thanks for changes made!
jinpingh
added a commit
to StackStorm/st2tests
that referenced
this pull request
Jul 26, 2019
With new improvement code StackStorm/st2#4743, if pack version is not provided, the latest version for pack from index.json is installed. Modify existing `e2e` test to check: 1. Install pack without version and check if the latest version for pack from index.json is installed. 2) install pack with version and check if the version specified is the version installed.
jinpingh
added a commit
to StackStorm/st2tests
that referenced
this pull request
Jul 26, 2019
With new improvement code StackStorm/st2#4743, if pack version is not provided, the latest version for pack from index.json is installed. Modify existing `e2e` test `tests.test_run_pack_tests_tool` to check: 1. Install pack without version and check if the latest version for pack from index.json is installed. `st2 pack install csv` 2) install pack with version and check if the version specified is the version installed. `st2 pack install xml=0.3.0
jinpingh
added a commit
to StackStorm/st2tests
that referenced
this pull request
Jul 27, 2019
With new improvement code StackStorm/st2#4743, if pack version is not provided, the latest version for pack from index.json is installed. Part of Fixes: https://github.com/StackStorm/discussions/issues/354 Modify existing `e2e` test `tests.test_run_pack_tests_tool` to check: 1. Install pack without version and check if the latest version for pack from index.json is installed. `st2 pack install csv` 2) install pack with version and check if the version specified is the version installed. `st2 pack install xml=0.3.0
m4dcoder
pushed a commit
to StackStorm/st2tests
that referenced
this pull request
Aug 14, 2019
With new improvement code StackStorm/st2#4743, if pack version is not provided, the latest version for pack from index.json is installed. Part of Fixes: https://github.com/StackStorm/discussions/issues/354 Modify existing `e2e` test `tests.test_run_pack_tests_tool` to check: 1. Install pack without version and check if the latest version for pack from index.json is installed. `st2 pack install csv` 2) install pack with version and check if the version specified is the version installed. `st2 pack install xml=0.3.0
This was referenced Apr 17, 2020
arm4b
pushed a commit
to StackStorm/st2docs
that referenced
this pull request
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of Fixes StackStorm/discussions#354.
If pack version is not specified, install the latest version from pack index.json (https://index.stackstorm.org/v1/index.json), otherwise install from master branch as today.
Note: Direct github/repo install is not considered an Exchange index hit, therefore it is not covert by this fix.
Closes #4384