Fix a possible shell command injection in the linux.service action #4675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kami
commented
May 13, 2019
| if len(sys.argv) < 3: | ||
| raise ValueError('Usage: service.py <action> <service>') | ||
|
|
||
| args = {'act': quote_unix(sys.argv[1]), 'service': quote_unix(sys.argv[2])} |
Member
Author
There was a problem hiding this comment.
This is now not strictly needed since subprocess.Popen already takes case of that when a list of args and shell=False is used.
jinpingh
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a possible shell command injection in
linux.serviceaction.Background, Context
The code didn't escape
serviceandactionparameter passed tosubprocess.Popenand usedshell=True.This pull request fixes the action to use
shell=Falseand passes command tosubprocess.Popenas a list of arguments instead of as a string (in this scenario, values are automatically escaped bysubprocess.Popen).This issue was reported to us by James Robinson (Netskope and Veracode).