Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Apr 15, 2019

Just some house keeping before the release.

I noticed we didn't pin bcrypt dependency so I also fixed that so we have reproducible builds.

@Kami Kami added this to the 3.0.0 milestone Apr 15, 2019
@Kami
Copy link
Member Author

Kami commented Apr 23, 2019

Per @LindsayHill - will also push a change to st2sdk so dependency versions there match versions defined here.

Copy link
Contributor

@LindsayHill LindsayHill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also pin jinja2 in st2actions/in-requirements.txt?

@Kami
Copy link
Member Author

Kami commented Apr 23, 2019

@LindsayHill in-requirements.txt only contain a list of requirements without version numbers. version numbers are specified in fixed-requirements.txt - https://github.com/StackStorm/st2/blob/master/CONTRIBUTING.rst#managing-python-dependencies

@LindsayHill
Copy link
Contributor

OK then

@Kami Kami merged commit 3d04093 into master Apr 24, 2019
@Kami Kami deleted the update_requirements branch April 24, 2019 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants