Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Feb 18, 2019

Changes in #4510 didn't add / correctly update flex in requirements.txt and re-generate final requirements.txt file so requirements file was out of date.

@Kami Kami added this to the 2.10.2 milestone Feb 18, 2019
@Kami Kami requested a review from blag February 18, 2019 09:50
@Kami
Copy link
Member Author

Kami commented Feb 18, 2019

@blag Just a heads up - https://github.com/StackStorm/st2/blob/master/CONTRIBUTING.rst#managing-python-dependencies

In short, fixed-requirements.txt is our dependency lock file and only file where we specify actual dependency versions. requirements.txt is auto generated and shouldn't be updated manually.

@Kami
Copy link
Member Author

Kami commented Feb 18, 2019

I some how missed change in #4552.

Closing this as duplicate and will continue there.

@Kami Kami closed this Feb 18, 2019
@arm4b arm4b deleted the fix_requirements branch February 18, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants