Skip to content

Conversation

@arm4b
Copy link
Member

@arm4b arm4b commented Mar 9, 2016

Autodetect specific st2 branch depending on st2-packages branch.

What this change brings

  • pushing to master of st2-packages repo will generate packages based on master of st2
  • pushing to v1.3 of st2-packages repo will generate packages based on v1.3 of st2
  • opening PR against master branch of st2-packages repo will use st2 master
  • opening PR against v1.3 branch of st2-packages repo will use st2 v1.3
  • opening PR against any other branch of st2-packages repo will use st2 master

This autodetect works for both Pull Requests and inside vX.Y and master branches of st2-packages repo.

Branch autodetection for PR is based on target branch:

armab wants to merge 1 commit into (--->) master from feature/branching

Fetch specific versioned `st2` branch depending on current `st2-packages` branch
@arm4b arm4b added the feature label Mar 9, 2016
@arm4b arm4b force-pushed the feature/branching branch from da50214 to 1b2fa6b Compare March 9, 2016 13:53
@arm4b arm4b added the RFR label Mar 9, 2016
@arm4b arm4b changed the title Follow st2 branching Follow st2 branching (master) Mar 9, 2016
@arm4b
Copy link
Member Author

arm4b commented Mar 9, 2016

As @enykeev correctly noted, autodetection won't work good enough with some PR cases:

you’re pushing it, it starts building, you’re creating a pr, you see test pass, you’re merging it, the merge fails

If you open PR and then merge more commits - it will autodetect target PR branch and will work well.
But it's error-prone way.

@arm4b arm4b closed this Mar 9, 2016
@arm4b arm4b deleted the feature/branching branch March 9, 2016 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants