loosen dependency version requirements #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could not build python-ldap on one machine that had openldap 2.6. And the pinned version of cachetools is from 2017 and does not technically support python3.8 until cachetools v3.1. So, loosen the requirements. Let the lockfile in the st2 repo handle pinning a precise version. This is a libraray, so it should not have deps locked down this far anyway. Deps should be locked at an app-level, not at a library level.
cognifloyd
added
enhancement
dependencies
cognifloyd
requested review from
a team,
amanda11,
arm4b,
nzlosh,
rush-skills and
winem
nzlosh
approved these changes
Feb 11, 2023
|
Looks like the tests weren't ran for this repo due to GHA expiration. Something is failing: https://github.com/StackStorm/st2-auth-ldap/actions/runs/4029527433/jobs/6927507250, probably was broken many months ago. If you have a few cycles to fix it, considering you tried building it recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not build python-ldap on one machine that had openldap 2.6.
And the pinned version of cachetools is from 2017 and does not technically support python3.8. Cachetools added support for python3.8 in v3.1.
Also, this is a libraray, so it should not have deps locked down this far anyway. Deps should be locked at an app-level, not at a library level.
So, loosen the requirements. Let the lockfile in the st2 repo handle pinning a precise version.