Add support for Python 3.x checks to pack Circle CI config #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for running various lint checks and pack tests under Python 3.6 (in addition to Python 2.7).
In addition to new Python 3 checks, I also added new "compile" check for Python 2.7 and Python 3.6 job which verifies Python syntax in pack files is valid.
A couple of things to keep in mind:
This will allow us to identify "problematic" packs. The goal is to add new
python_versionattribute topack.yamlfile and utilize that attribute in CI to determine if pack supports Python 3. For packs which claim support for Python 3, build will fail if Python 3 checks fail, and for ones which don't, it wont (will open a PR for that in StackStorm/st2 shortly).st2sdkbecause CI scripts use StackStorm from git checkout and all the shebangs in scripts in the repo explicitly default to python2.7 binary.TODO