Skip to content

Clean#343

Merged
Christian-B merged 57 commits into
masterfrom
clean
Jan 21, 2026
Merged

Clean#343
Christian-B merged 57 commits into
masterfrom
clean

Conversation

@Christian-B
Copy link
Copy Markdown
Member

@Christian-B Christian-B commented Jan 5, 2026

builds on / fixes #342
builds on SpiNNakerManchester/spinnaker_tools#201

UtilsDataView

  • tracks map of database_key to logs{key}.sqlite3 path
  • added though register_binary_search_path
    • calls _register_log_database (also used by tests)
    • Adds the deprecated_database_file spinn_utilities/make_tools/logs.sqlie3 if still there
  • retrieved through get_log_database_path
    • If testing os RUNNER_ENVIRONMENT set will error if key not find
    • in normal will just warn and return None
      • replacer will then just return the line as read of the machine
  • mock clears the map

convertor

  • Must now be given a scr dir, modified dir, dir for the database and key for the database
  • single Database and FileConvertor object used for the whole directory
  • files sorted for a constant order/number
  • No longer clears the database
    • Make has to do it

file_converter

  • call replaced with init and convert methods
    • init object shared by several convert calls
  • database key added in from of message id

LogSqlLiteDatabase

  • No longer told if it is a new_dict or not
    • init simplifed
    • clear call removed
  • methods to go from database key to filename and back again
  • methods to find the logs databases and keys given a directory

Replacer

  • gets database paths from DataView
  • caches these for speed
  • Looks for the database key to get the correct database
    • Which could be the deprecated_database_file is no make was done

cfg external_binaries no longer used at this level

tests changed for new format.
Special notes
unittests/make_tools/test_database_keys.py

  • Can be run after all makes to list / check the unique database keys

Must be done at the same time as:
SpiNNakerManchester/spinnaker_tools#201
SpiNNakerManchester/spinn_common#91
SpiNNakerManchester/PACMAN#619
SpiNNakerManchester/SpiNNFrontEndCommon#1334
SpiNNakerManchester/sPyNNaker#1621
SpiNNakerManchester/SpiNNakerGraphFrontEnd#323
SpiNNakerManchester/sPyNNakerNewModelTemplate#127
SpiNNakerManchester/SpiNNGym#108
SpiNNakerManchester/SpiNNaker_PDP2#101
SpiNNakerManchester/microcircuit_model#49
SpiNNakerManchester/MarkovChainMonteCarlo#84
https://github.com/SpiNNakerManchester/BitBrainDemo/pull/92
https://github.com/SpiNNakerManchester/TSPonSpiNNaker/pull/70
SpiNNakerManchester/IntegrationTests#336
SpiNNakerManchester/SupportScripts#94

requires:
SpiNNakerManchester/sPiNNIRker#42 UNTESTED as repository is behind

tests
SpiNNakerManchester/PyNNExamples#134

@Christian-B Christian-B merged commit 65bc4bf into master Jan 21, 2026
12 checks passed
@Christian-B Christian-B deleted the clean branch January 21, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants