Fix S6964 FP: Properties decorated with the [BindNever] attribute #9361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
requested changes
May 30, 2024
Contributor
mary-georgiou-sonarsource
left a comment
mary-georgiou-sonarsource
left a comment
There was a problem hiding this comment.
I'll see this again after rebase 🎉
zsolt-kolbay-sonarsource
force-pushed
the
Zsolt/fix-S6964-FP-BindNeverAttribute
branch
from
cab38c0 to
c8ad6c4
Compare
analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/AvoidUnderPosting.cs
Outdated
Show resolved
Hide resolved
mary-georgiou-sonarsource
approved these changes
May 30, 2024
Contributor
mary-georgiou-sonarsource
left a comment
mary-georgiou-sonarsource
left a comment
There was a problem hiding this comment.
LGTM - just a minor thing to fix also in another PR.
Co-authored-by: Mary Georgiou <[email protected]>
|
|
zsolt-kolbay-sonarsource
deleted the
Zsolt/fix-S6964-FP-BindNeverAttribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9360