Skip to content

Reproducer for Metrics analyzer for Razor: Lines of code are outside the range of the file #9289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martin-strecker-sonarsource wants to merge 4 commits into from
Closed

Reproducer for Metrics analyzer for Razor: Lines of code are outside the range of the file #9289

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70ec115
Add test case
martin-strecker-sonarsource May 16, 2024
bd8aaf0
Simplify test
martin-strecker-sonarsource May 16, 2024
9279ac9
Add "Expected" test case and more comments
martin-strecker-sonarsource May 16, 2024
d1cff87
Fix comment
martin-strecker-sonarsource May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 76 additions & 0 deletions analyzers/tests/SonarAnalyzer.Test/Common/MetricsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,82 @@ End Sub
End Class").Should().BeEquivalentTo(new[] { 1, 2, 3, 4, 5, 6, 7, 8 });
}

[TestMethod]
// https://github.com/SonarSource/sonar-dotnet/issues/9288
public void LinesOfCode_Razor()
{
/* File.razor:
@using System.Net.Http
@using static Microsoft.AspNetCore.Components.Web.RenderMode
*/
// In the .Net 9 SDK the generated code misses #line default and #line hidden for all @using except the last one
var generated = """
#pragma checksum "File.razor" "{8829d00f-11b8-4213-878b-770e8597ac16}" "751c4a07609c64113e523665ea31f1888133ad09656f3360c19ac90145e14e6b"
#line (1,2)-(2,1) "File.razor"
using System.Net.Http

#nullable disable
;
#nullable restore
#line (2,2)-(2,61) "File.razor"
using static Microsoft.AspNetCore.Components.Web.RenderMode

#line default
#line hidden
#nullable disable
;
#nullable restore
""";
const string FileName = "File.razor.g.cs";
var compilation = SolutionBuilder.Create()
.AddProject(AnalyzerLanguage.CSharp)
.AddSnippet(generated, FileName)
.GetCompilation();
var tree = compilation.SyntaxTrees.SingleOrDefault(x => x.FilePath == "File.razor.g.cs");
var semanticModel = compilation.GetSemanticModel(tree);
var lineNumbers = new Metrics.CSharp.CSharpMetrics(tree, semanticModel).CodeLines;
lineNumbers.Should().BeEquivalentTo([1, 4, 2]); // Line number 4 is outside the range of the file
}

[TestMethod]
// https://github.com/SonarSource/sonar-dotnet/issues/9288
public void LinesOfCode_Razor_Expected()
{
/* File.razor:
@using System.Net.Http
@using static Microsoft.AspNetCore.Components.Web.RenderMode
*/
// This is how the generated code should look like
var generated = """
#pragma checksum "File.razor" "{8829d00f-11b8-4213-878b-770e8597ac16}" "751c4a07609c64113e523665ea31f1888133ad09656f3360c19ac90145e14e6b"
#line (1,2)-(2,1) "File.razor"
using System.Net.Http

#line default
#line hidden
#nullable disable
;
#nullable restore
#line (2,2)-(2,61) "File.razor"
using static Microsoft.AspNetCore.Components.Web.RenderMode

#line default
#line hidden
#nullable disable
;
#nullable restore
""";
const string FileName = "File.razor.g.cs";
var compilation = SolutionBuilder.Create()
.AddProject(AnalyzerLanguage.CSharp)
.AddSnippet(generated, FileName)
.GetCompilation();
var tree = compilation.SyntaxTrees.SingleOrDefault(x => x.FilePath == "File.razor.g.cs");
var semanticModel = compilation.GetSemanticModel(tree);
var lineNumbers = new Metrics.CSharp.CSharpMetrics(tree, semanticModel).CodeLines;
lineNumbers.Should().BeEquivalentTo([1, 2]);
}

[TestMethod]
public void CommentsWithoutHeaders()
{
Expand Down