Open
Conversation
Open
|
The preview deployment for frontend-testownik-dev is ready. 🟢 Open Preview | Open Build Logs | Open Application Logs Last updated at: 2026-02-24 22:23:20 CET |
Antoni-Czaplicki
requested changes
Feb 24, 2026
Comment on lines
+37
to
+49
| other: { | ||
| "application/ld+json": JSON.stringify({ | ||
| "@context": "https://schema.org", | ||
| "@type": "Quiz", | ||
| name: metadata.title, | ||
| description: metadata.description, | ||
| numberOfQuestions: metadata.question_count, | ||
| author: { | ||
| "@type": "Person", | ||
| name: metadata.maintainer?.full_name, | ||
| }, | ||
| }), | ||
| }, |
Member
There was a problem hiding this comment.
actually quizzes should be excluded from search engines
Comment on lines
+25
to
+29
| if (isGuest) { | ||
| return { | ||
| title: "Quiz", | ||
| }; | ||
| } |
Member
There was a problem hiding this comment.
i would still try to fetch as guest user can use shared quizzes
Comment on lines
+17
to
+19
| export async function generateMetadata({ | ||
| params, | ||
| }: PageProps<"/quiz/[quizId]">): Promise<Metadata> { |
Member
There was a problem hiding this comment.
do you think we should use https://nextjs.org/docs/app/api-reference/functions/generate-metadata#with-cache-components?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #95
Zmiany
Do każdego zdjęcia nie posiadającego parametru
altdodano go. Wszystkie z nich były zdjęciami użytkownika/grupy.Dodatkowo: Poprawiono dostępność - do przycisków nie posiadający żadnej opisowej nazwy dodano
aria-labelz odpowiednią nazwą.Ocena raportu Lighthouse dla home page'a.1
Ocena raportu Lighthouse dla home page'a po wprowadzonych zmianach.12
Do zrobienia kiedyś
await fetch(...)do generacji metadata dla quizu na poprawny endpoint, kiedy będzie takowy istniał.Footnotes
Pole
Performancemoże się różnić dla różnych raportów i pokazuje metrykę tylko w chwili sporządzania raportu ↩ ↩2Poprawiono accessibility dla każdej podstrony (chyba niczego nie pominąłem) do przynajmniej 98 ↩