hvt_module_net: do not return EAGAIN on a read of 0 bytes#618
Open
hannesm wants to merge 1 commit intoSolo5:mainfrom
Open
hvt_module_net: do not return EAGAIN on a read of 0 bytes#618hannesm wants to merge 1 commit intoSolo5:mainfrom
hannesm wants to merge 1 commit intoSolo5:mainfrom
Conversation
Collaborator
|
I'm really not sure about that, we should really look into the expected behavior between reading on a TAP interface and what the unikernel expect. I would really like to emphasise that #559 points a behaviour that is not expected if a file descriptor is used instead of a tap interface (which is also not expected). |
Merged
Contributor
Author
I did, so mirage-net-solo5 behaves fine with an empty buffer received. I also tried to lookup when a read of a tap interface will return 0, without success (so I couldn't find any documentation or code). For other bindings, I can't see any special path if the network read returns 0. |
Contributor
Author
|
But I'm also fine to close this, and the issue 559. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #559 //cc @reynir