Initialize logging before Pyctuator #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelyaakoby
requested changes
Sep 2, 2020
Member
michaelyaakoby
left a comment
michaelyaakoby
left a comment
There was a problem hiding this comment.
Can you add some more info in the commit comment?
Maybe refer to the issue (by including "#31" in the comment).
Maybe even add a short explanation of the problem.
Contributor
Author
|
Validated fixes are working on all example apps |
Member
|
I agree with @michaelyaakoby regarding the commit message. Consider using the form of "Before this change, (describe previous behavior here). Now, (describe new behavior here)" |
MatanRubin
reviewed
Sep 2, 2020
yanoom
force-pushed
the
yanay-fix-issue-31-app-logging-conf
branch
from
3f2e65c to
a889949
Compare
This allows calls to `logging.<log_level>` to be printed in console, even after Pyctuator's initialization. Before this change, application needed to call `logging.basicConfig` or `logging.<any log level>` before initiating Pyctuator (otherwise Pyctuator has the only handler in logging module, and app prints do not appear in console). Fixes #31
yanoom
force-pushed
the
yanay-fix-issue-31-app-logging-conf
branch
from
a889949 to
b3ef885
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows calls to
logging.<log_level>to be printed in console, even after Pyctuator's initialization