Fix for benchmark & More refactoring#817
Merged
yrong merged 3 commits intorefactor-beacon-clientfrom May 1, 2023
Merged
Conversation
Merged
vgeddes
reviewed
Apr 28, 2023
Collaborator
vgeddes
left a comment
vgeddes
left a comment
There was a problem hiding this comment.
Thanks Ron! Since you started refactoring is_valid_merkle_branch, I added more ideas for how to improve it.
vgeddes
approved these changes
May 1, 2023
Collaborator
vgeddes
left a comment
vgeddes
left a comment
There was a problem hiding this comment.
OK, looks good. Just please add the const_assert back.
yrong
force-pushed
the
ron/refactor-beacon-client
branch
from
44091f1 to
3accff4
Compare
Collaborator
|
Sounds good! |
yrong
added a commit
that referenced
this pull request
May 1, 2023
* Refactor types * more refactoring * refactor * refactor * refactor * refactor * refactor * update cumulus * Update benchmarks * Update template for generating benchmarking data * Fix bug in tests to prevent stack overflow * Fix for benchmark & More refactoring (#817) * Fix for benchmark & More refactoring * More refactoring * Add const_assert back --------- Co-authored-by: Ron <yrong1997@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.