Skip to content

Furthur upgrade the contracts#1735

Merged
yrong merged 5 commits intomainfrom
ron/upgrade-contracts
Mar 5, 2026
Merged

Furthur upgrade the contracts#1735
yrong merged 5 commits intomainfrom
ron/upgrade-contracts

Conversation

@yrong
Copy link
Copy Markdown
Contributor

@yrong yrong commented Mar 4, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.60%. Comparing base (da414f1) to head (39955af).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
contracts/src/upgrade/Gateway202603.sepolia.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1735   +/-   ##
=======================================
  Coverage   76.60%   76.60%           
=======================================
  Files          24       24           
  Lines         979      979           
  Branches      186      186           
=======================================
  Hits          750      750           
  Misses        205      205           
  Partials       24       24           
Flag Coverage Δ
solidity 76.60% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yrong yrong marked this pull request as ready for review March 4, 2026 02:22
@yrong
Copy link
Copy Markdown
Contributor Author

yrong commented Mar 4, 2026

I encountered an error when testing a P->E transfer, specfically when executing the following extrinsic on Westend Asset Hub (WAH):

https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fwestend-asset-hub-rpc.polkadot.io#/extrinsics/decode/0x1f0305140008010000078af3f3602e020109079edaa802000bb099a7c3260130010000078af3f3602e1608140d01020c000101005827013ddc4082f8252f8729bd2f06e77e7863dea9202a6f0e7a2c34e356e85a31020109079edaa80201020004020109079edaa8020007b08902ef3d0104020004020109079edaa80200070010a5d4e8080d01020c00010300302f0b71b8ad3cf6dd90adb668e49b2168d652fd2cfbed09f79d7767547bcf30154760029fa6845a62b0ef10c783f1ebbae7ad5fe92cfbed09f79d7767547bcf30154760029fa6845a62b0ef10c783f1ebbae7ad5fe90700ac23fc0602093d00

The error occurs during signAndSend (specifically at here, the transaction was not included in a block and returned the following result:

{
  dispatchError: undefined,
  dispatchInfo: undefined,
  events: [],
  internalError: undefined,
  status: 'Invalid'
}

However, performing a dry-run succeeds, which suggests the issue may be related to Polkadot.js rather than the runtime itself.

I attempted upgrading @polkadot/api to 16.5.4, but the issue persists.

"@polkadot/keyring": "14.0.1",
"@polkadot/types": "16.5.4",
"@polkadot/util": "14.0.1",
"@polkadot/util-crypto": "14.0.1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thought these were out of support!

Copy link
Copy Markdown
Contributor Author

@yrong yrong Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alistair-singh I’ve confirmed that it works on PAH but not on WAH. I also verified that the Rust smoke tests pass on WAH, which suggests the above issue is most likely related to PJS.

Since PJS is now in maintenance mode, does this mean we should consider migrating to PAPI instead?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There must be some new addition on WAH that makes this break. Potentially metadata.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to be related to the Dwellir endpoints. The issue was resolved after switching to the Parity endpoints.

d895588

Copy link
Copy Markdown
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yrong yrong merged commit 1437081 into main Mar 5, 2026
2 checks passed
@yrong yrong deleted the ron/upgrade-contracts branch March 5, 2026 03:23
@yrong yrong mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants