Parachain Relayer V2 by yrong · Pull Request #1321 · Snowfork/snowbridge

yrong · 2024-10-22T17:11:05Z

Resolves: https://linear.app/snowfork/issue/SNO-1230
Requires: paritytech/polkadot-sdk#6706

vgeddes · 2024-10-24T17:28:38Z

relayer/relays/parachain/types_v2.go

-	Fee         types.U128
+	Nonce       uint64
+	BlockNumber uint32
+	Fee         big.Int


If you use types.UCompact then you won't need to write a custom decoder.

Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>

Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>

vgeddes · 2025-01-21T18:27:09Z

relayer/relays/parachain/parachain-writer.go

+	"golang.org/x/sync/errgroup"
+)
+
+func (relay *Relay) startDeliverProof(ctx context.Context, eg *errgroup.Group) error {


Problem here is that we're taking on the responsibility of handling all delivery proofs.

There may be multiple instances of the parachain relayer, each of which only relays messages according to different criteria. Each instance should only handle its own delivery proofs.

Instead, we know that the ethereum-writer calls wr.gateway.V2Submit() after which we have access to the delivery proof. Wouldnt it better to have this algorithm:

Ethereum-writer submits message to Gateway

Ethereum-writer finds receipt for completed transaction, get InboundMessageDispatched log and pushes it on queue deliveryReceipts

The parachain-writer reads from the deliveryReceipts queue and submits proof to parachain.

pushes it on queue deliveryReceipts

@vgeddes Could you elaborate a bit more about the deliveryReceipts queue, is that on-chain storage or some kind of off-chain global storage like Redis?

It would just be a go channel used to communicate within the relayer process

We can send delivery proof only after the beacon block is finalized, so there's a long wait between step 2 and step 3. If the relayer stops/restarts for any reason during that period, we could miss sending the proof.

So IMO we may still need the background startDeliverProof running periodically to find the pending orders and submit delivery proof for these orders.

Btw: 24230d7 for filtering the order by rewardAddress to handle the relayer's own delivery proof.

* Contracts V2 (#1300) * Ethereum Relayer V2 (#1341) * v2 initial commit * latest changes * Flesh out dispatch logic for inbound messages * Add reward address * make code compile * Split initializer impl into a library to reduce contract size * Major refactor * Update tests * add scripts back * Update scripts * Finish outbound messaging * Implement token registration for V2 * Make functions payable * improve docs * comments * review feedback * cleanups * Add initial tests for V2 * Make `rewardAddress` an indexed event parameter * Clean up interfaces * Make WETH address configurable * Autowrap ether * auto-unwrap ether * Add view keyword * off-chain part * off-chain changes * improve * improve * allow unlocking native ether * improve token registration flows * improve docs * improve * improve * nit * Update contracts/src/v1/Calls.sol Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> * Apply suggestions from code review Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> * Fix unlock WETH * Suppress Error (6243): The "tload" instruction * Merge recent changes * add foundry setting * relayer progress * fixes * adds xcm * register token v2 * clean up register token smoketest * fmt * merge damage * fix tests * send token and relayer fixes * relayer cleanup and transact * send token to penpal smoke test * syntax error * adds penpal test to ci * merge damage fixes --------- Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com> Co-authored-by: ron <yrong1997@gmail.com> Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> * Parachain Relayer V2 (#1321) * v2 initial commit * latest changes * Flesh out dispatch logic for inbound messages * Add reward address * make code compile * Split initializer impl into a library to reduce contract size * Major refactor * Update tests * add scripts back * Update scripts * Finish outbound messaging * Implement token registration for V2 * Make functions payable * improve docs * Parachain relayer V2 * Rename to PendingOrder * Decode compact int * comments * Improve doc * review feedback * cleanups * Add initial tests for V2 * Make `rewardAddress` an indexed event parameter * Remove unused * Submit delivery proof * Rename to InboundMessageV2 * Mark as view function * Filter with reward address * Clean up interfaces * Make WETH address configurable * Autowrap ether * V2 smoke tests (#1327) * Update contracts for smoke tests * Remove unused * Decode test * Update subxt * Register PNA with OutbountQueueV2 * Fix storage key * Comment out config * Revert contract changes * Fix function * Regenerate binds & update package path * Format * Format * Add todo * Update bindings * Update script * auto-unwrap ether * Update smoke tests * Add view keyword * More refactoring * Verify V2 digest for commitment * Call Contract with value * improve * improve * allow unlocking native ether * improve token registration flows * improve docs * improve * improve * nit * Fix smoke test for V2 * Fix test * Fix unlock WETH * Sync with contract * Fix smoke test * Update contracts/src/v1/Calls.sol Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> * Apply suggestions from code review Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> * Fix unlock WETH * Suppress Error (6243): The "tload" instruction * Merge recent changes * Fix breaking tests * Fix tests * Filter order by rewardAddress to handle own delivery proof * Fix test * Add ofac check --------- Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> * Fix V2 tests (#1378) * Fix smoke tests * Add smoke tests * Prefund transfer ENA * Create agent (#1388) * Create agent on Ethereum * Add test * Fix forge test * Revamp smoke test * Update go bindings * Add register relay token back * Fix transfer pna * Remove obsolete code * Update contracts/src/v2/Types.sol Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com> * Update foundry.toml * Rename follow the naming scheme * Fix smoke test * Fix function name --------- Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com> * Fix test coverage reports (#1390) * Gateway should no longer build token registration XCM (#1381) * Rather build register token on BH * Add comments * adds metadata fields to register token * Revert "adds metadata fields to register token" This reverts commit 90cbff5. * update tests * Cleanup * Update bindings * remove kusama as supported network --------- Co-authored-by: claravanstaden <claravanstaden64@gmail.com> Co-authored-by: ron <yrong1997@gmail.com> * Improve smoke tests (#1396) * Rather build register token on BH * Add comments * adds metadata fields to register token * Revert "adds metadata fields to register token" This reverts commit 90cbff5. * update tests * Cleanup * Update bindings * Fix smoke test send token to destination chain * Rename path * Add send pna * Check amount --------- Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com> Co-authored-by: claravanstaden <claravanstaden64@gmail.com> * cherry-pick token changes from main * Revert "cherry-pick token changes from main" This reverts commit 9731690. * Improve ERC20 implementation (#1384) * Add more docs * Log topic on ethereum side (#1404) * Log topic on ethereum side * Fix test * Update relayer --------- Co-authored-by: ron <yrong1997@gmail.com> * Delete obsolete code * improve comments * cleanups after static analysis * Remove handlers for deprecated V1 commands * format code * format comments * Refactor agent creation code * Add test for foreign token registration * Add tests for mint foreign token * Improve docs * Update bindings * Merge from V1 (#1422) * Add support for ether (#1409) * Upgrade gateway on Sepolia for westend (#1407) * Log gateway codehash * Upgrade Gateway on Westend-Sepolia * Update indexer endpoint & Cleanup (#1411) * Ban lido token (#1412) * Fix hardcoded url (#1414) * Register Polkadot Native Assets in Control Tool (#1405) * added function to register tokens * fmt * fix build errors * clean up * more assets * fix message * more tokens * Update control/preimage/src/commands.rs --------- Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> * Force rebuild (#1418) * Update with V1 bindings * Remove channel config * Remove channel * Remove topic id from InboundMessageDispatched * Format codes (#1416) * Generate delivery receipt * Revert "Remove topic id from InboundMessageDispatched" This reverts commit 7e77f49. modified: smoketest/src/helper.rs modified: web/packages/test/scripts/build-binary.sh * Fix script * Clean up unused code * Cleanup * Minor fix * Fix binding * Change storage location * Fix template --------- Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> * Merge updates from V1 (#1429) * Add support for ether (#1409) * Upgrade gateway on Sepolia for westend (#1407) * Log gateway codehash * Upgrade Gateway on Westend-Sepolia * Update indexer endpoint & Cleanup (#1411) * Ban lido token (#1412) * Fix hardcoded url (#1414) * Register Polkadot Native Assets in Control Tool (#1405) * added function to register tokens * fmt * fix build errors * clean up * more assets * fix message * more tokens * Update control/preimage/src/commands.rs --------- Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> * Force rebuild (#1418) * Format codes (#1416) * remove equilibrium and its stable coin (#1421) * Hot fix (#1424) * Update Bifrost RPC endpoint * Update package * Update geth to v.15.5 in order to support decoding of SetCodeTx (#1426) * update geth to v.15.5 in order to support decoding of SetCodeTx * update go to 1.23.0 * update Go version in CI * fix breaking test * Cleanup --------- Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Parth <desaiparth08@gmail.com> * For V1 compatibility (#1428) * Merge recent changes from V1 * Fix smoke tests * Update go.work.sum * Improve smoke tests --------- Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: ron <yrong1997@gmail.com> Co-authored-by: Alistair Singh <alistair.singh7@gmail.com> Co-authored-by: Parth <desaiparth08@gmail.com>

vgeddes and others added 19 commits October 2, 2024 14:46

v2 initial commit

e0b2371

latest changes

a7ad609

Flesh out dispatch logic for inbound messages

1be9e5c

Add reward address

e7fecaf

make code compile

08715b0

Split initializer impl into a library to reduce contract size

111f738

Major refactor

b0867e8

Update tests

ee37e3c

add scripts back

6829f38

Update scripts

8c878ce

Merge branch 'v2' into vincent/v2

0b25864

Finish outbound messaging

c35743d

Implement token registration for V2

149c3e4

Make functions payable

02ac263

improve docs

c7332c3

Parachain relayer V2

c8fc265

Rename to PendingOrder

a64c2a5

Decode compact int

f72e9c3

comments

c0bab8a

vgeddes reviewed Oct 24, 2024

View reviewed changes

yrong and others added 8 commits October 25, 2024 12:07

Merge branch 'vincent/v2' into ron/v2

2d9aaf9

Improve doc

c5f0a24

review feedback

eae219e

cleanups

318b7dc

Add initial tests for V2

e73125d

Make rewardAddress an indexed event parameter

fa9b8a7

Remove unused

e611e3a

Submit delivery proof

e3888db

yrong force-pushed the ron/v2 branch from d26c6bd to e3888db Compare October 28, 2024 07:45

Merge branch 'vincent/v2' into ron/v2

bdb0ac1

vgeddes and others added 15 commits December 7, 2024 22:33

improve

7378735

nit

4e17456

Fix smoke test for V2

f54ad7c

Fix test

1e168c3

Merge branch 'vincent/v2' into ron/v2

0d0046b

Fix unlock WETH

9081585

Sync with contract

b75a480

Fix smoke test

d162fd3

Update contracts/src/v1/Calls.sol

fc48f45

Co-authored-by: Clara van Staden <claravanstaden64@gmail.com>

Apply suggestions from code review

e35cd91

Co-authored-by: Alistair Singh <alistair.singh7@gmail.com>

Fix unlock WETH

55e6cab

Suppress Error (6243): The "tload" instruction

005da17

Merge branch 'vincent/v2' into ron/v2

8ec8306

Merge recent changes

d77abee

Merge branch 'vincent/v2' into ron/v2

8b63e4a

vgeddes reviewed Jan 21, 2025

View reviewed changes

Base automatically changed from vincent/v2 to v2 January 30, 2025 12:45

yrong added 3 commits February 1, 2025 22:36

Merge branch 'v2' into ron/v2

980b3ec

Fix breaking tests

2a9abb4

Merge branch 'v2' into ron/v2

95e565a

github-actions bot added Component: Smoke Tests Component: Web labels Feb 2, 2025

yrong added 4 commits February 2, 2025 13:49

Fix tests

c84fe3b

Filter order by rewardAddress to handle own delivery proof

24230d7

Fix test

66906d5

Add ofac check

9cf8d92

yrong mentioned this pull request Feb 3, 2025

V2 #1371

Merged

yrong merged commit 08e2bb0 into v2 Feb 3, 2025

yrong deleted the ron/v2 branch February 3, 2025 07:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parachain Relayer V2#1321

Parachain Relayer V2#1321
yrong merged 82 commits intov2from
ron/v2

yrong commented Oct 22, 2024 •

edited

Loading

Uh oh!

vgeddes Oct 24, 2024

Uh oh!

vgeddes Jan 21, 2025 •

edited

Loading

Uh oh!

yrong Jan 23, 2025

Uh oh!

vgeddes Jan 23, 2025

Uh oh!

yrong Feb 2, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

yrong commented Oct 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vgeddes Oct 24, 2024

Choose a reason for hiding this comment

Uh oh!

vgeddes Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yrong Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

vgeddes Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

yrong Feb 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yrong commented Oct 22, 2024 •

edited

Loading

vgeddes Jan 21, 2025 •

edited

Loading

yrong Feb 2, 2025 •

edited

Loading