Skip to content

Fix sibling location#1077

Merged
yrong merged 9 commits intomainfrom
ron/fix-sibling-location
Dec 21, 2023
Merged

Fix sibling location#1077
yrong merged 9 commits intomainfrom
ron/fix-sibling-location

Conversation

@yrong
Copy link
Contributor

@yrong yrong commented Dec 20, 2023

Address for the comment paritytech/polkadot-sdk#2522 (comment)
Resolves: SNO-803

@codecov
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7e2f8b1) 80.69% compared to head (334857e) 80.69%.
Report is 1 commits behind head on main.

Files Patch % Lines
parachain/primitives/router/src/outbound/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1077   +/-   ##
=======================================
  Coverage   80.69%   80.69%           
=======================================
  Files          55       55           
  Lines        2274     2274           
  Branches       71       71           
=======================================
  Hits         1835     1835           
  Misses        422      422           
  Partials       17       17           
Flag Coverage Δ
solidity 80.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yrong yrong marked this pull request as ready for review December 20, 2023 08:41
use xcm_builder::{DescribeAllTerminal, DescribeFamily, HashedDescription};

pub type AgentIdOf = HashedDescription<H256, DescribeFamily<DescribeAllTerminal>>;
pub type AgentIdOf = HashedDescription<H256, (DescribeHere, DescribeFamily<DescribeAllTerminal>)>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're also repeating this line in the BridgeHub xcm_config.rs configuration, can you check?

In which case we should factor out both definitions into our parachain/runtime/runtime-common crate.

Copy link
Contributor Author

@yrong yrong Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, several duplications and refactoring with 8c1d1d8

Btw, prefer to move to primitives as it's very low level and not only used in runtime.

Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yrong yrong merged commit 491d9ba into main Dec 21, 2023
@yrong yrong deleted the ron/fix-sibling-location branch December 21, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants