Merged
Conversation
claravanstaden
commented
Nov 30, 2023
|
|
||
| parameter_types! { | ||
| // Network and location for the Ethereum chain. | ||
| pub EthereumNetwork: NetworkId = NetworkId::Ethereum { chain_id: 15 }; |
Contributor
Author
There was a problem hiding this comment.
I'll make a follow up PR to change this to chain ID 5, for Goerli.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
=======================================
Coverage 80.99% 80.99%
=======================================
Files 52 52
Lines 2152 2152
Branches 68 68
=======================================
Hits 1743 1743
Misses 394 394
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned here: paritytech/polkadot-sdk#2522 (comment)
Used here in the polkadot-sdk: Snowfork/polkadot-sdk@a5b1964