gles: Define a GlesContext, with a CurrentGlesContext guard#1750
Draft
ids1024 wants to merge 2 commits intoSmithay:masterfrom
Draft
gles: Define a GlesContext, with a CurrentGlesContext guard#1750ids1024 wants to merge 2 commits intoSmithay:masterfrom
GlesContext, with a CurrentGlesContext guard#1750ids1024 wants to merge 2 commits intoSmithay:masterfrom
Conversation
Member
Author
|
I guess Edit: For modularity the |
ids1024
force-pushed
the
gles-context
branch
from
d1fb940 to
279aa1e
Compare
Start using `GlesContext` helper Use GlesContext helper in more places import_egl_image() needs to take `&mut self` Use context helper more WIP WIP WIP WIP TODO call_without_current WIP XXX XXX texture_program call_without_current Make current XXX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still working through issues to use this everywhere. The goal is to prevent things like #1748.
In particular,
GlesFrameneeds to be updated to hold aCurrentGlesContext. Things likeblit_to/bllit_fromare a little funny here since they call a function that makes a different context current, then restore the context.