x11: Use xinput2, and ignore key repetition#1535
Merged
Drakulix merged 2 commits intoSmithay:masterfrom Sep 18, 2024
Merged
Conversation
ids1024
force-pushed
the
input
branch
2 times, most recently
from
05fb5f1 to
313d1ca
Compare
If we require dri3 and present, it should be fair to assume xinput2 as well. This will be needed if we want to add touch and gesture events, etc.
This backend should avoid producing key press events for key repeat, the libinput backend. You can see in `wev` that this prevents repeated key press events on held keys that don't happen with libinput.
ids1024
added a commit
to pop-os/cosmic-comp
that referenced
this pull request
Sep 18, 2024
Not supressing key repetition in backends seems like it was a bug, and should be fixed as of Smithay/smithay#1535. So an argument for this should be unnecessary now.
Drakulix
pushed a commit
to pop-os/cosmic-comp
that referenced
this pull request
Sep 19, 2024
Not supressing key repetition in backends seems like it was a bug, and should be fixed as of Smithay/smithay#1535. So an argument for this should be unnecessary now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The winit backend (and libinput backend) already don't produce key repeat events like this.