Skip to content

fix: account for angular acceleration in swerve angle kinematics constraint#1453

Merged
calcmogul merged 2 commits intoSleipnirGroup:mainfrom
spacey-sooty:account-for-angular-accel-in-kinematics
Mar 23, 2026
Merged

fix: account for angular acceleration in swerve angle kinematics constraint#1453
calcmogul merged 2 commits intoSleipnirGroup:mainfrom
spacey-sooty:account-for-angular-accel-in-kinematics

Conversation

@spacey-sooty
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the component: trajoptlib TrajoptLib label Mar 23, 2026
@spacey-sooty
Copy link
Collaborator Author

Doesn't seem to meaningfully impact feasibility or generation time from my brief tests.

@spacey-sooty spacey-sooty requested a review from calcmogul March 23, 2026 06:57
Copy link
Member

@calcmogul calcmogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but needs formatter run.

@spacey-sooty spacey-sooty requested a review from calcmogul March 23, 2026 16:19
@calcmogul
Copy link
Member

calcmogul commented Mar 23, 2026

Huh. This change sped up the solve time for the following trajectory from 4.4 s to 1.3 s.

Choreo GUI:
Screenshot_20260323_094141

Solver diagnostics with main:
Screenshot_20260323_094622

Solver diagnostics with this PR:
Screenshot_20260323_094506

@calcmogul calcmogul merged commit 57d281b into SleipnirGroup:main Mar 23, 2026
30 checks passed
@spacey-sooty spacey-sooty deleted the account-for-angular-accel-in-kinematics branch March 23, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants