Skip to content

Conversation

Added `--open` flag to automatically open web browser for docs dev.
@backpackbot
Copy link

Backpack Bot (backpackbot) commented Oct 25, 2017

Warnings
⚠️

One or more packages have changed, but changelog.md wasn't updated.

Messages
📖

Thanks for the PR 🎉.

Generated by 🚫 dangerJS

"storybook": "start-storybook -p 9001",
"sassdoc": "sassdoc {packages/bpk-mixins/src/**/*,packages/bpk-svgs/dist/*,packages/bpk-tokens/tokens/base.default}.scss -d dist/sassdoc -v --strict --debug",
"docs": "webpack-dev-server",
"docs": "webpack-dev-server --open",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! 🎉

@matthewdavidson
Copy link
Contributor Author

I've tested storybook dev (npm start), docs dev (npm run docs) and docs prod output (npm run docs:dist && http-server dist).

Copy link
Contributor

@k0nserv Hugo Tunius (k0nserv) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Surprised we didn't have to make any code changes with the Webpack 3 upgrade etc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/******/
/******/ // Load entry module and return exports
/******/ return __webpack_require__(__webpack_require__.s = 1);
/******/ return __webpack_require__(__webpack_require__.s = 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find in the links you posted where this change comes from - what does it do?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewdavidson
Copy link
Contributor Author

Hugo Tunius (@k0nserv) me too - for comparison, here is CRA's webpack 3 upgrade PR facebook/create-react-app#2574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants