Improving namings of GQI DS and adding script folders.#6
Merged
Conversation
Closed
Member
|
OK to me. |
# Conflicts: # SchedulerTasks/CatalogInformation/Images/Scheduler_Occurrences_SettingUp_75pct.png
Collaborator
Author
|
@jarno-lernou This branch now contains renamed input parameter, folder added, and image updated to reflect new name of the input parameter. Would you mind giving it a quick review again, just to make sure no other changes are needed? |
jarno-lernou-skyline
approved these changes
Jul 2, 2025
Member
jarno-lernou-skyline
left a comment
jarno-lernou-skyline
left a comment
There was a problem hiding this comment.
All good, just one comment unrelated to the pull request. Are you aware of Using the Scheduler NuGet package | DataMiner Docs?
Collaborator
Author
Yes, I originally tried using it in the solution, but the methods that nuget provides rely on Engine.SLNetRaw which caused issues within the ad hoc data sources in the package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed name of DS, added Folder.