Skip to content

Minor Chat Rule Fixes #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AzureAaron merged 3 commits into from
Apr 11, 2026
+6 −7
Merged

Minor Chat Rule Fixes #2311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dfd19d
Fix NPE if attempting to replace a nonexistent capture group
Alex33856 Apr 10, 2026
84b09f1
Fix sliders not working
Alex33856 Apr 10, 2026
a59a992
checkstyle
Alex33856 Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/de/hysky/skyblocker/skyblock/chat/ChatRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,11 @@ protected String insertCaptureGroups(String replaceMessage) {
Matcher m = matcher.get();
m.reset();
if (!m.find()) return replaceMessage; // shouldn't happen but you never know
m.appendReplacement(sb, replaceMessage);
try {
m.appendReplacement(sb, replaceMessage);
} catch (IndexOutOfBoundsException | IllegalArgumentException _) {
return replaceMessage;
}
return sb.substring(m.start());
}
}
Expand Down
7 changes: 1 addition & 6 deletions src/main/java/de/hysky/skyblocker/utils/render/gui/RangedSliderWidget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public RangedSliderWidget(int x, int y, int width, int height, double defaultVal
this.step = step;
this.formatter = formatter;
this.callback = callback;
setValue(defaultValue);
setValue(valueToProgress(defaultValue));
}

private double roundToNearestStep(double value) {
Expand All @@ -45,11 +45,6 @@ protected void updateMessage() {
setMessage(this.formatter.apply(getValue()));
}

public void setValue(double value) {
this.value = valueToProgress(value);
this.updateMessage();
}

public double getValue() {
return roundToNearestStep(progressToValue(this.value));
}
Expand Down
Loading