Delay listening behavior logic until after the event implementation initializes#6948
Merged
APickledWalrus merged 3 commits intoSkriptLang:dev/patchfrom Aug 1, 2024
Merged
Conversation
getEventClasses() may depend on the impl's init
APickledWalrus
added
bug
sovdeeth
approved these changes
Jul 31, 2024
Moderocky
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an error that could occur for events that depend on
initto determine the values forgetEventClasses(). This caused an error with EvtMove as listening behavior attempted to usegetEventClassesbefore it was ready (that is, before EvtMove initialized). This error only occurred on Spigot (where entity move does not exist)Target Minecraft Versions: any
Requirements: none
Related Issues: