Conversation
sovdeeth
requested changes
Apr 12, 2023
src/main/java/ch/njol/skript/classes/data/DefaultFunctions.java
Outdated
Show resolved
Hide resolved
src/main/java/ch/njol/skript/classes/data/DefaultFunctions.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/elements/expressions/ExprTextOf.java
Outdated
Show resolved
Hide resolved
...in/java/org/skriptlang/skript/elements/expressions/displays/text/ExprTextDisplayOpacity.java
Outdated
Show resolved
Hide resolved
sovdeeth
requested changes
Apr 13, 2023
Member
sovdeeth
left a comment
There was a problem hiding this comment.
Looks good, mainly just went through the docs part this time.
src/main/java/org/skriptlang/skript/elements/expressions/displays/ExprDisplayInterpolation.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/elements/expressions/displays/ExprDisplayHeightWidth.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/elements/expressions/displays/ExprDisplayGlowOverride.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/elements/expressions/displays/ExprDisplayBillboard.java
Outdated
Show resolved
Hide resolved
...a/org/skriptlang/skript/elements/expressions/displays/ExprDisplayTransformationRotation.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/elements/expressions/displays/ExprDisplayViewRange.java
Outdated
Show resolved
Hide resolved
.../java/org/skriptlang/skript/elements/expressions/displays/text/ExprTextDisplayLineWidth.java
Outdated
Show resolved
Hide resolved
Co-authored-by: sovdee <ethansovde@gmail.com>
sovdeeth
reviewed
Apr 13, 2023
sovdeeth
approved these changes
Apr 13, 2023
Member
sovdeeth
left a comment
There was a problem hiding this comment.
Just a slightly more clear version of this sentence, and the axisangle thing you already acknowledged, and I'm satisfied.
nice work!
src/main/java/org/skriptlang/skript/elements/expressions/displays/ExprDisplayHeightWidth.java
Outdated
Show resolved
Hide resolved
cheeezburga
reviewed
Aug 22, 2024
Member
cheeezburga
left a comment
There was a problem hiding this comment.
Nothing code-related, just some very small nitpicky things with descriptions and stuff
src/main/java/org/skriptlang/skript/bukkit/misc/expressions/ExprItemOfEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/expressions/ExprItemOfEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/expressions/ExprItemOfEntity.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/expressions/ExprRotate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/expressions/ExprRotate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/expressions/ExprRotate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/displays/generic/ExprDisplayBillboard.java
Outdated
Show resolved
Hide resolved
Co-authored-by: cheeezburga <47320303+cheeezburga@users.noreply.github.com>
Co-authored-by: cheeezburga <47320303+cheeezburga@users.noreply.github.com>
cheeezburga
reviewed
Aug 31, 2024
src/main/java/ch/njol/skript/classes/data/DefaultFunctions.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/displays/generic/ExprDisplayHeightWidth.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/effects/EffRotate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/effects/EffRotate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/effects/EffRotate.java
Outdated
Show resolved
Hide resolved
Co-authored-by: cheeezburga <47320303+cheeezburga@users.noreply.github.com>
cheeezburga
approved these changes
Aug 31, 2024
# Conflicts: # build.gradle # src/main/java/ch/njol/skript/Skript.java # src/main/java/ch/njol/skript/classes/data/DefaultFunctions.java # src/main/java/ch/njol/skript/classes/data/JavaClasses.java # src/main/java/ch/njol/skript/classes/data/SkriptClasses.java # src/main/java/ch/njol/skript/effects/EffVectorRotateAroundAnother.java # src/main/java/ch/njol/skript/effects/EffVectorRotateXYZ.java # src/main/java/ch/njol/skript/expressions/ExprBlockData.java # src/main/java/ch/njol/skript/expressions/ExprColorOf.java # src/main/java/ch/njol/skript/expressions/ExprItemFrameSlot.java # src/main/java/ch/njol/skript/expressions/ExprVectorXYZ.java # src/main/java/ch/njol/skript/registrations/DefaultClasses.java # src/main/java/ch/njol/skript/util/ColorRGB.java
APickledWalrus
requested changes
Sep 21, 2024
Member
APickledWalrus
left a comment
There was a problem hiding this comment.
Looking good. Here's what I found this time around.
Also, it might be good to have more javadocs (at least at the class level) for the Rotator implementations.
src/main/java/org/skriptlang/skript/bukkit/misc/rotation/NonMutatingVectorRotator.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/rotation/QuaternionRotator.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/rotation/VectorRotator.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/rotation/package-info.java
Show resolved
Hide resolved
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
APickledWalrus
requested changes
Oct 2, 2024
Member
APickledWalrus
left a comment
There was a problem hiding this comment.
Truly excellent work. Just a few things, and then this should be ready to ship
src/main/java/org/skriptlang/skript/bukkit/displays/DisplayData.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/displays/generic/ExprDisplayViewRange.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/displays/text/ExprTextDisplayLineWidth.java
Outdated
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/rotation/NonMutatingQuaternionRotator.java
Show resolved
Hide resolved
src/main/java/org/skriptlang/skript/bukkit/misc/rotation/NonMutatingVectorRotator.java
Show resolved
Hide resolved
Co-authored-by: Patrick Miller <apickledwalrus@gmail.com>
APickledWalrus
approved these changes
Oct 2, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds entity hiding because Spigot was finally forced to with these Displays.Download
Many people rely on this pull request. If you also wish to use this experimental version, go to the "checks" tab and then click Java 17, it'll have a skript-nightly.zip containing the built jar of this pull request.
Documentation at https://docs.skriptlang.org/nightly/feature/displays/docs.html
Ender chest loot box opening where it spins around and dumps out the contents as the reward (Requires Biosphere2)
Video of animation in #showcase https://discord.com/channels/135877399391764480/1072217309852213298/1111482138924163082
Target Minecraft Versions: 1.19.4
Requirements: none, but paper for some.
Related Issues: none