Open
Conversation
mwevill
force-pushed
the
mjw/get-sotrageconfig
branch
5 times, most recently
from
3af44f4 to
a825b8e
Compare
mwevill
requested review from
CloudPlatformer,
EwanNoble,
chelnak,
rivoric and
smneal
mwevill
force-pushed
the
mjw/get-sotrageconfig
branch
from
a825b8e to
0978493
Compare
chelnak
suggested changes
Dec 17, 2018
Contributor
chelnak
left a comment
chelnak
left a comment
There was a problem hiding this comment.
Might be worth wrapping everything from l34 in a try catch
try {
catch {
throw "$_"
}
0978493 to
e12d8a9
Compare
chelnak
reviewed
Dec 17, 2018
mwevill
force-pushed
the
mjw/get-sotrageconfig
branch
from
e12d8a9 to
c076828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.