Add support for decoding tiff images with CieLab color space #2127
Conversation
src/ImageSharp/Formats/Tiff/PhotometricInterpretation/CieLabPlanarTiffColor{TPixel}.cs
Outdated
Show resolved
Hide resolved
src/ImageSharp/Formats/Tiff/PhotometricInterpretation/CieLabTiffColor{TPixel}.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Günther Foidl <[email protected]>
| where TPixel : unmanaged, IPixel<TPixel> | ||
| { | ||
| // Note: The image from MagickReferenceDecoder does not look right, maybe we are doing something wrong | ||
| // converting the pixel data from Magick.NET to our format with CieLab? |
There was a problem hiding this comment.
What's happening here?
There was a problem hiding this comment.
The image Tiff\CieLab.tiff looks wrong when using the MagickReferenceDecoder:
It should look like this:
ImageMagick itself can decode this image just fine, that's why I thought we maybe doing something wrong in MagickReferenceDecoder.
There was a problem hiding this comment.
Ah right.... Yep,
IMagickImage<T> contains ColorSpace enum which we are blindly ignoring when converting. I always assumed they did the same as us and converted color spaces on decode.
It looks like we should be checking that first and converting on the fly.
@dlemstra Am I correct here?
JimBobSquarePants
left a comment
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Just checked the ref vs input. Looks great! 👍 Nice work!
Prerequisites
Description
This PR adds support for decoding Tiff images with the CieLab color space.