Use helper methods to access clip tables #1803
Conversation
- Make bitmask static readonly - Add aggresive inlining - Change Guard to DebugGuard in ReadValue
Codecov Report
@@ Coverage Diff @@
## master #1803 +/- ##
==========================================
- Coverage 87.30% 87.10% -0.21%
==========================================
Files 936 936
Lines 47855 47848 -7
Branches 6011 6010 -1
==========================================
- Hits 41780 41678 -102
- Misses 5085 5176 +91
- Partials 990 994 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| InitializeFixedCostsI4(); | ||
| } | ||
|
|
||
| private static readonly byte[] Abs0Table = |
There was a problem hiding this comment.
Make these use the ReadOnlySpan-trick?
Cf. #1799 (comment)
It's already used in this class e.g. in LogTable8Bit (above).
There was a problem hiding this comment.
Before I make this change, i would like to ask for other opinions on that matter. Should we really go all in with that trick and change all byte, sbyte arrays to ReadOnlySpan here?
Prerequisites
Description
This is a follow up PR to #1800: As suggested by @antonfirsov, the clip tables are now accessed via methods.
Also adds some minor improvements to
Vp8LBitReader