Skip to content

Conversation

@brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

I have overlooked a mistake in #1362: The reference output needed to be in the submodule repository.

@brianpopow brianpopow added the bug label Sep 26, 2020
@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #1363 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1363   +/-   ##
=======================================
  Coverage   82.77%   82.77%           
=======================================
  Files         690      690           
  Lines       30975    30975           
  Branches     3511     3511           
=======================================
  Hits        25641    25641           
  Misses       4613     4613           
  Partials      721      721           
Flag Coverage Δ
#unittests 82.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee30c71...16402d4. Read the comment docs.

@brianpopow
Copy link
Collaborator Author

i will go ahead and merge this

@brianpopow brianpopow merged commit 4dadf24 into master Sep 26, 2020
@brianpopow brianpopow deleted the feature/fix1362 branch September 26, 2020 15:51
JimBobSquarePants pushed a commit that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants