Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fix #1167

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #1180 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1180      +/-   ##
==========================================
- Coverage   82.47%   82.47%   -0.01%     
==========================================
  Files         690      690              
  Lines       29916    29918       +2     
  Branches     3379     3380       +1     
==========================================
  Hits        24674    24674              
- Misses       4541     4542       +1     
- Partials      701      702       +1     
Flag Coverage Δ
#unittests 82.47% <50.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...mory/DiscontiguousBuffers/MemoryGroupExtensions.cs 89.32% <0.00%> (-1.77%) ⬇️
src/ImageSharp/Memory/Buffer2D{T}.cs 93.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df81b3...960bc2a. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Seems too expensive to properly test this corner case on Buffer2D<T>.

@JimBobSquarePants JimBobSquarePants merged commit 6e08eb3 into master Apr 22, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/fix-1167 branch April 22, 2020 07:08
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IndexOutOfRange Exception in newest myget package

3 participants