Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Removes the TPixel type parameter from the ToBase64String(this Image source, IImageFormat format) method as it was unnecessary. Also fleshed out the intellisense documentation to correctly show the example output.

@JimBobSquarePants JimBobSquarePants added this to the 1.0.0-rc1 milestone Apr 18, 2020
@JimBobSquarePants JimBobSquarePants requested a review from a team April 18, 2020 15:57
Copy link
Member

@tocsoft tocsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #1175 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1175   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files         684      684           
  Lines       29519    29519           
  Branches     3328     3328           
=======================================
  Hits        24324    24324           
  Misses       4507     4507           
  Partials      688      688           
Flag Coverage Δ
#unittests 82.40% <ø> (ø)
Impacted Files Coverage Δ
src/ImageSharp/ImageExtensions.cs 68.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de73c63...406573c. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit a8a7a43 into master Apr 18, 2020
@JimBobSquarePants JimBobSquarePants deleted the js/base-64-extension branch April 18, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants