SpectralConverter.CommitConversion fails in Debug

[antonfirsov]

ImageSharp version

2.0

Other ImageSharp packages and versions

N/A

Environment (Operating system, version and so on)

any

.NET Framework version

any

Description

The following assertion fails in almost all of our baseline jpeg tests:

ImageSharp/src/ImageSharp/Formats/Jpeg/Components/Decoder/SpectralConverter.cs

Lines 47 to 49 in e54219a

	public void CommitConversion()
	{
	DebugGuard.IsFalse(this.Converted, nameof(this.Converted), $"{nameof(this.CommitConversion)} must be called only once");

@br3aker any idea why is CommitConversion called multiple times? Could this lead to actual issues?

Steps to Reproduce

Run JpegDecoderTests.DecodeBaselineJpeg in Debug.

Images

No response

[br3aker]

That's strange, I've tested it locally and it worked. Will wokr on it asap.

Could this lead to actual issues?

Most likely no but nothing should call it multiple times.

[antonfirsov]

I've tested it locally and it worked

Hm hope it's not some black magic on my machine only.

[br3aker]

Can confirm, already found a bug (it's a very silly one).

Why did CI passed it? Doesn't it have a DEBUG job?

[antonfirsov]

Why did CI passed it? Doesn't it have a DEBUG job?

Unfortunately, no. IMO, would be nice to have it at least against one target framework. Alternatively, we can introduce Checked build configuration, so avoid very long Debug test runs.