Backpack Loadout Category#957
Merged
VMSolidus merged 8 commits intoSimple-Station:masterfrom Sep 28, 2024
Merged
Conversation
github-actions
bot
added
Changes: Localization
github-actions
bot
added
Changes: C#
OldDanceJacket
approved these changes
Sep 25, 2024
Member
Author
|
Wait shit don't hit merge yet, we need @DEATHB4DEFEAT to do the Database Migration for this, or else all of our downstreams will be forced to delete their databases. |
ShadesMars
added
Size: 4-Small
Member
Author
|
Okay the Migration is ready to go |
ShadesMars
approved these changes
Sep 27, 2024
ShadesMars
requested review from
a team and
DEATHB4DEFEAT
and removed request for
a team
ShadesMars
added
Priority: 2-High
SimpleStation14
added a commit
that referenced
this pull request
Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#794 apparently silently deprecated the Backpack Preferences button. Selecting a backpack preference no longer actually does anything, and instead your backpack comes from your Loadout. This would have been fine if we were warned about this, but because nobody merged upstream for 2 weeks after the release of PR794, this issue went unreported.
Well now the solution is going to require adding every backpack in the entire game to a new Backpacks tab. I've started this PR, but because it's really late and I have Calculus classes in the morning, I won't be able to finish it tonight. So I'm enlisting the help of a few other people I know to PR to this PR to help get the backpacks in.
After we have backpacks in the loadout tab, and after Wizmerge, I'll probably do a separate PR to actually remove the now useless Backpack selection button.
This is probably for the better long term. Since this technically means Backpack slots are no longer hardcoded to "Backpack/Duffelbag/Satchel", and now the back slot is freeeeee to be used for anything.
Media
Changelog
🆑