Skip to content

Cherry-Pick #28077#898

Merged
VMSolidus merged 1 commit intoSimple-Station:masterfrom
VMSolidus:Fix-Sandbox-Failures
Sep 14, 2024
Merged

Cherry-Pick #28077#898
VMSolidus merged 1 commit intoSimple-Station:masterfrom
VMSolidus:Fix-Sandbox-Failures

Conversation

@VMSolidus
Copy link
Copy Markdown
Member

Description

Cherry-Picks space-wizards/space-station-14#28077
For our downstreams so that they don't get sandbox violation errors when attempting to compile with the Latest Dotnet 8

Roslyn now compiles char + string with string.Concat(ROS<char>). This means doing ref char -> ROS<char> which is not sandbox safe. Actually fixing this in the sandboxer is difficult so I'm gonna just pass on that for now.
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: UI Changes any XAML files labels Sep 9, 2024
@ShadesMars ShadesMars added Priority: 2-High Needs to be resolved soon Size: 5-Very Small For especially small issues/PRs labels Sep 14, 2024
@VMSolidus VMSolidus merged commit 8b93cec into Simple-Station:master Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: C# Changes any cs files Changes: UI Changes any XAML files Priority: 2-High Needs to be resolved soon Size: 5-Very Small For especially small issues/PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants