Disable Quick Swap for Item Slots by Default#856
Merged
VMSolidus merged 6 commits intoSimple-Station:masterfrom Sep 8, 2024
Merged
Disable Quick Swap for Item Slots by Default#856VMSolidus merged 6 commits intoSimple-Station:masterfrom
VMSolidus merged 6 commits intoSimple-Station:masterfrom
Conversation
This reverts commit 0d8ae2c.
SimpleStation14
changed the title
Contributor
|
having to actually use hands to interact with things ??? crazy ! |
Contributor
|
make it a cvar |
Contributor
Author
Not sure how to achieve that since the assignment happens in the primary constructor of the class. |
DEATHB4DEFEAT
approved these changes
Sep 8, 2024
Member
Modify it on init |
Contributor
Author
|
Better solution. (turns out this property is only used in 1 place anyway) |
VMSolidus
approved these changes
Sep 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As was discussed on discord, quick swap is a feature that makes certain things needlessly easy. You can instantly swap the magazine in a gun without even paying attention to it, you can quickly swap cells in IPCs/borgs, you can instantly swap the ID in your pda with that of someone else without anyone noticing, et cetera. In my opinion, this is unnecessary QOL that makes the game feel more bland and primitive. Besides, it used to lead to odd and unwanted behavior, such as IPCs being able to swap their own power cells.
In addition to that, certain entities do not support quick swap. For instance, rechargers will stop working if you insert a power cell and then quick-swap it before it finishes charging.
This PR makes quick swap disabled by default. It can still be re-enabled by setting
ItemSlotsComponent.Slots.[ItemSlot].Swap = trueon individual entities.Changelog
🆑