Fix Translators Not Working Correctly Under Certain Conditions#834
Merged
VMSolidus merged 2 commits intoSimple-Station:masterfrom Sep 8, 2024
Merged
Conversation
SimpleStation14
changed the title
Contributor
Author
|
test fail fake |
DEATHB4DEFEAT
approved these changes
Sep 3, 2024
VMSolidus
approved these changes
Sep 8, 2024
SimpleStation14
added a commit
that referenced
this pull request
Sep 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This completely refactors the translator system, fixing various issues, such as being unable to hold multiple translators at once normally, entity languages not getting updated properly if a translator was removed from it via stripping or similar, etc.
Also fixes translators being utter shitcode.
Media
weeee-2024-08-31_14.05.50.mp4
Changelog
🆑