Skip to content

Remove the Stupid Station Records Check From News#739

Merged
VMSolidus merged 1 commit intoSimple-Station:masterfrom
Mnemotechnician:fix/news
Aug 18, 2024
Merged

Remove the Stupid Station Records Check From News#739
VMSolidus merged 1 commit intoSimple-Station:masterfrom
Mnemotechnician:fix/news

Conversation

@Mnemotechnician
Copy link
Copy Markdown
Contributor

@Mnemotechnician Mnemotechnician commented Aug 17, 2024

Description

It was never used but caused annoyance all the time: the listening post could never use the news console and ghosts/centcom officials/skeletons could never publish news because of it.

(This was not tested, I recommend either waiting til I test it or making someone else test it before merging)

Changelog

🆑

  • fix: You no longer need to have a station record to publish news.

Signed-off-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
@github-actions github-actions bot added the Changes: C# Changes any cs files label Aug 17, 2024
@SimpleStation14 SimpleStation14 changed the title Remove the stupid station records check from news Remove the Stupid Station Records Check From News Aug 17, 2024
@ShatteredSwords
Copy link
Copy Markdown
Contributor

That is a super weird error from Build and Test, but I don't think it has anything to do with what you edited.

@Mnemotechnician
Copy link
Copy Markdown
Contributor Author

Mimic test fail. It's fine.

@Mnemotechnician
Copy link
Copy Markdown
Contributor Author

Tested; works as intended.

image

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Aug 18, 2024
@DangerRevolution DangerRevolution added Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Type: Bug [Un]intentional issue with something Type: Cleanup Like Rework but small labels Aug 18, 2024
@VMSolidus VMSolidus merged commit b7fe64c into Simple-Station:master Aug 18, 2024
SimpleStation14 added a commit that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changes: C# Changes any cs files Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Status: Needs Review Someone please review this Type: Bug [Un]intentional issue with something Type: Cleanup Like Rework but small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants