Zombie Improvements Take 2#652
Merged
DangerRevolution merged 2 commits intoSimple-Station:masterfrom Aug 4, 2024
Merged
Conversation
DangerRevolution
approved these changes
Aug 3, 2024
DangerRevolution
suggested changes
Aug 3, 2024
Contributor
DangerRevolution
left a comment
There was a problem hiding this comment.
Cl entry explains nothing about this PR
Member
Author
Done. |
DangerRevolution
approved these changes
Aug 4, 2024
DEATHB4DEFEAT
approved these changes
Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem: "Players like to stall zombie rounds"
Solution: Fix the Anti-Stall mechanic.
The set of functions for handling the automatic shuttle call now correctly only checks "The" station, rather than any grid containing a StationDataComponent. By using the less permissive _gameTicker.GetSpawnableStations(); function, the zombie gamerule no longer includes stations such as Centcomm, Planet Expeditions, some salvage wrecks, certain space ships, the Syndicate Listening Outpost, and Nukie World. Additionally, the check for "Healthy" humans no longer considers anyone infected with the zombie virus to be a "Healthy" human, ensuring that someone with a 200u jug of Bicaridine can no longer contribute to round stalling. Finally, dead (player)zombies are now by default checked for the purpose of calling the evac shuttle. The reason being for this assumption, is that dead zombies are still players removed from the round. If a majority of players are removed from the round(or fucked off to space), the shuttle should be called.
Changelog
🆑