Fix Talking Across Docked Grids#593
Merged
OldDanceJacket merged 2 commits intoSimple-Station:masterfrom Jul 26, 2024
Merged
Conversation
DEATHB4DEFEAT
approved these changes
Jul 25, 2024
DEATHB4DEFEAT
added
Priority: 2-High
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com> Signed-off-by: VMSolidus <evilexecutive@gmail.com>
OldDanceJacket
approved these changes
Jul 26, 2024
SimpleStation14
added a commit
that referenced
this pull request
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#574 introduced a bug whereby people who are each on separate grids, but the grids were attached, could not talk to each other. I have corrected this by making it so that when the Cross-Grid check is handled, it also checks to see if the two different grids are JOINTed to each other. Therefore allowing sound to travel across the connection. This should also work from Shuttle To Planet, since it's also handled via the same system. This means that docked shuttles allow sound to travel across to the docked station(or other shuttle), as well as shuttles docked to a planet's surface will permit sound to travel to the planet.
Changelog
🆑